Browse Source

Fix code quality issues (#2118)

pull/2140/head
Shubhendra Singh Chauhan 7 months ago
committed by GitHub
parent
commit
15303e32cf
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 6 additions and 6 deletions
  1. +2
    -2
      controllers/route.go
  2. +1
    -1
      imap/monitor.go
  3. +1
    -1
      middleware/ratelimit/ratelimit.go
  4. +1
    -1
      models/email_request.go
  5. +1
    -1
      models/maillog.go

+ 2
- 2
controllers/route.go View File

@ -301,7 +301,7 @@ func (as *AdminServer) nextOrIndex(w http.ResponseWriter, r *http.Request) {
next = path
}
}
http.Redirect(w, r, next, 302)
http.Redirect(w, r, next, http.StatusFound)
}
func (as *AdminServer) handleInvalidLogin(w http.ResponseWriter, r *http.Request, message string) {
@ -386,7 +386,7 @@ func (as *AdminServer) Login(w http.ResponseWriter, r *http.Request) {
as.handleInvalidLogin(w, r, "Invalid Username/Password")
return
}
if u.AccountLocked == true {
if u.AccountLocked {
as.handleInvalidLogin(w, r, "Account Locked")
return
}

+ 1
- 1
imap/monitor.go View File

@ -174,7 +174,7 @@ func checkForNewEmails(im models.IMAP) {
log.Error("Error updating GoPhish email with rid ", rid, ": ", err.Error())
continue
}
if im.DeleteReportedCampaignEmail == true {
if im.DeleteReportedCampaignEmail {
deleteEmails = append(deleteEmails, m.SeqNum)
}
}

+ 1
- 1
middleware/ratelimit/ratelimit.go View File

@ -91,7 +91,7 @@ func (limiter *PostLimiter) Cleanup() {
limiter.Lock()
defer limiter.Unlock()
for ip, bucket := range limiter.visitors {
if time.Now().Sub(bucket.lastSeen) >= limiter.expiry {
if time.Since(bucket.lastSeen) >= limiter.expiry {
delete(limiter.visitors, ip)
}
}

+ 1
- 1
models/email_request.go View File

@ -144,7 +144,7 @@ func (s *EmailRequest) Generate(msg *gomail.Message) error {
log.Error(err)
}
// don't set the Subject header if it is blank
if len(subject) != 0 {
if subject != "" {
msg.SetHeader("Subject", subject)
}

+ 1
- 1
models/maillog.go View File

@ -215,7 +215,7 @@ func (m *MailLog) Generate(msg *gomail.Message) error {
log.Warn(err)
}
// don't set Subject header if the subject is empty
if len(subject) != 0 {
if subject != "" {
msg.SetHeader("Subject", subject)
}

Loading…
Cancel
Save